Type fixes for createModel(), InsertEvent, RemoveEvent, Subscribable

derbyjs · Apr 8, 2024 · aae0fb4 · aae0fb4
1 parent ff9adb7
commit aae0fb4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/Model/events.ts b/src/Model/events.ts
@@ -653,7 +653,7 @@ export class InsertEvent {
   declare type: 'insert';
   declare _immediateType: 'insertImmediate';
   index: number;
-  values: any;
+  values: any[];
   passed: any;
 
   constructor(index, values, passed) {
@@ -678,8 +678,9 @@ export class RemoveEvent {
   declare _immediateType: 'removeImmediate';
   index: number;
   passed: any;
-  removed: any;
-  values: any;
+  removed: any[];
+  /** @deprecated Use `removed` instead */
+  values: any[];
 
   constructor(index, values, passed) {
     this.index = index;

diff --git a/src/Model/subscriptions.ts b/src/Model/subscriptions.ts
@@ -9,7 +9,7 @@ const promisify = util.promisify;
 /**
  * A path string, a `Model`, or a `Query`.
  */
-export type Subscribable = string | Model<unknown> | Query;
+export type Subscribable = string | Model<unknown> | Query<unknown>;
 
 declare module './Model' {
   interface Model<T> {

diff --git a/src/index.ts b/src/index.ts
@@ -27,7 +27,7 @@ export {
 
 export const racer = new Racer();
 
-export function createModel(data) {
+export function createModel(data?) {
   var model = new RootModel();
   if (data) {
     model.createConnection(data);