Index out of bounds on lint nodes

[gabeduke]

Describe the bug
After linting nodes panic: index out of range is being thrown.

To Reproduce
Steps to reproduce the behavior:
This error occurs consistently on multiple clusters in our environment.

Expected behavior
lint should complete

Screenshots

(etcd cluster is also master role)

[...]
NODES                                                     💥 0 😱 5 🔊 0 ✅ 6 55٪
┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅
  · ip-10-46-33-196.ec2.internal...............................................✅
  · ip-10-46-33-63.ec2.internal................................................😱
    😱 Found taint `dedicated but no pod can tolerate.
  · ip-10-46-34-24.ec2.internal................................................😱
    😱 Found taint `dedicated but no pod can tolerate.
  · ip-10-46-35-165.ec2.internal...............................................✅
  · ip-10-46-38-218.ec2.internal...............................................✅
  · ip-10-46-38-51.ec2.internal................................................😱
    😱 Found taint `dedicated but no pod can tolerate.
  · ip-10-46-39-186.ec2.internal...............................................✅
  · ip-10-46-39-50.ec2.internal................................................😱
    😱 Found taint `dedicated but no pod can tolerate.
  · ip-10-46-40-86.ec2.internal................................................😱
    😱 Found taint `dedicated but no pod can tolerate.
  · ip-10-46-41-33.ec2.internal................................................✅
  · ip-10-46-43-8.ec2.internal.................................................✅

panic: runtime error: index out of range

goroutine 1 [running]:
github.com/derailed/popeye/internal/k8s.(*Client).InUseNamespaces(0xc0000ae940, 0xc000573300, 0x1, 0x1)
	/Users/fernand/go_wk/derailed/src/github.com/derailed/popeye/internal/k8s/client.go:116 +0x29f
github.com/derailed/popeye/internal/linter.(*Namespace).Lint(0xc0000ba6d0, 0x2276c40, 0xc00027f780, 0x206bc9b, 0x2)
	/Users/fernand/go_wk/derailed/src/github.com/derailed/popeye/internal/linter/ns.go:30 +0xcf
github.com/derailed/popeye/pkg.(*Popeye).Sanitize(0xc000709d40)
	/Users/fernand/go_wk/derailed/src/github.com/derailed/popeye/pkg/popeye.go:62 +0x217
github.com/derailed/popeye/cmd.doIt(0x2db09a0, 0x2ddbcd8, 0x0, 0x0)
	/Users/fernand/go_wk/derailed/src/github.com/derailed/popeye/cmd/root.go:56 +0xdf
github.com/spf13/cobra.(*Command).execute(0x2db09a0, 0xc00003a020, 0x0, 0x0, 0x2db09a0, 0xc00003a020)
	/Users/fernand/go_wk/derailed/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:766 +0x2ae
github.com/spf13/cobra.(*Command).ExecuteC(0x2db09a0, 0x0, 0x0, 0xc0003fff88)
	/Users/fernand/go_wk/derailed/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852 +0x2ec
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/fernand/go_wk/derailed/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800
github.com/derailed/popeye/cmd.Execute()
	/Users/fernand/go_wk/derailed/src/github.com/derailed/popeye/cmd/root.go:43 +0x32
main.main()
	/Users/fernand/go_wk/derailed/src/github.com/derailed/popeye/main.go:19 +0x20
$ kubectl get nodes                                                                                                                                                                                                          2 ↵
NAME                           STATUS   ROLES    AGE     VERSION
ip-10-46-33-196.ec2.internal   Ready    worker   6h20m   v1.12.3
ip-10-46-33-63.ec2.internal    Ready    master   6h30m   v1.12.3
ip-10-46-34-24.ec2.internal    Ready    master   6h30m   v1.12.3
ip-10-46-35-165.ec2.internal   Ready    master   6h20m   v1.12.3
ip-10-46-38-218.ec2.internal   Ready    worker   6h20m   v1.12.3
ip-10-46-38-51.ec2.internal    Ready    master   6h29m   v1.12.3
ip-10-46-39-186.ec2.internal   Ready    master   6h20m   v1.12.3
ip-10-46-39-50.ec2.internal    Ready    master   6h28m   v1.12.3
ip-10-46-40-86.ec2.internal    Ready    master   6h29m   v1.12.3
ip-10-46-41-33.ec2.internal    Ready    worker   6h20m   v1.12.3
ip-10-46-43-8.ec2.internal     Ready    master   6h28m   v1.12.3

Versions (please complete the following information):

• OS: 10.14.3
• Popeye 0.1.2
• K8s 1.12.3

Additional context
Add any other context about the problem here.

[derailed]

@gabeduke Thank you for the report! I think I've fixed this issue. Could you please try v0.1.3 and report back? Tx!!

[gabeduke]

This is resolved thanks! Looks great!