Skip to content

Commit

Permalink
update release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
derailed committed Aug 12, 2019
1 parent f05fca1 commit ac0ac7f
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Build...
FROM golang:1.12.3-alpine AS build

ENV VERSION=v0.4.2 GO111MODULE=on PACKAGE=github.com/derailed/popeye
ENV VERSION=v0.4.3 GO111MODULE=on PACKAGE=github.com/derailed/popeye

WORKDIR /go/src/$PACKAGE

Expand Down
26 changes: 26 additions & 0 deletions change_logs/release_v0.4.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<img src="https://raw.githubusercontent.com/derailed/popeye/master/assets/popeye.png" align="right" width="200" height="auto"/>

# Release v0.4.3

## Notes

Thank you so much for your support and suggestions to make Popeye better!!

If you dig this tool, please make some noise on social! [@kitesurfer](https://twitter.com/kitesurfer)

---

## Change Logs

Maintenance release bugs and cleanup.

---

## Resolved Bugs

* Wrong Popeye version in Docker builds [Issue #48](https://github.com/derailed/popeye/issues/48)
* Incorrect ServiceAccount reporting [Issue #49](https://github.com/derailed/popeye/issues/49)

---

<img src="https://raw.githubusercontent.com/derailed/popeye/master/assets/imhotep_logo.png" width="32" height="auto"/>&nbsp; © 2019 Imhotep Software LLC. All materials licensed under [Apache v2.0](http://www.apache.org/licenses/LICENSE-2.0)
6 changes: 5 additions & 1 deletion internal/sanitize/sa.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,12 @@ func (s *ServiceAccount) Sanitize(ctx context.Context) error {
}

func (s *ServiceAccount) checkSecretRefs(fqn string, refs []v1.ObjectReference) {
ns, _ := namespaced(fqn)
for _, ref := range refs {
sfqn := cache.FQN(ref.Namespace, ref.Name)
if ref.Namespace != "" {
ns = ref.Namespace
}
sfqn := cache.FQN(ns, ref.Name)
if _, ok := s.ListSecrets()[sfqn]; !ok {
s.AddCode(304, fqn, sfqn)
}
Expand Down

0 comments on commit ac0ac7f

Please sign in to comment.