Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass set retries to transfer command #2596

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

nobbs
Copy link
Contributor

@nobbs nobbs commented Mar 5, 2024

The newly introduced retries field in the transfer dialog was not passed to the transfer command. This commit fixes that.

Follow-up of #2584

The newly introduced retries field in the transfer dialog was not
passed to the transfer command. This commit fixes that.

Follow-up of derailed#2584
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nobbs Indeed! Thank for this update Alej!!

@derailed derailed merged commit 0403a93 into derailed:master Mar 6, 2024
3 checks passed
@nobbs
Copy link
Contributor Author

nobbs commented Mar 6, 2024

@derailed heads up: the pr also contained a change you already did in the meanwhile, so now the code contains that line twice:

k9s/internal/view/pod.go

Lines 329 to 333 in 0403a93

opts = append(opts, fmt.Sprintf("--retries=%d", args.Retries))
if args.CO != "" {
opts = append(opts, "-c="+args.CO)
}
opts = append(opts, fmt.Sprintf("--retries=%d", args.Retries))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants