Add namespace for rolebinding on a clusterrole #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>
In the above example, you can see the namespace filled in, but only for the rows granted via the The other rows are granted via ClusterRoleBinding. |
Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>
Merged
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
* add namespace for rolebinding on a clusterrole Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com> * remove unused function Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com> --------- Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ClusterRole can be attached to a ServiceAccount via a RoleBinding, granting access only to a specific namespace. This PR adds the namespace name to the ServiceAccount Policy view, for ClusterRoles bound with a RoleBinding.
Fixes #2169
Implementation
I modified the existing code, to keep a map of all the RoleBindings types mapped to namespace.