fix: (config) only respect the --command flag once #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinoute
reviewed
May 18, 2023
We want to switch to the command specified by the flag, but only at startup. Afterwards, we should be interactive and favor the user's command choices over the startup commandline switch.
derailed
approved these changes
May 21, 2023
There was a problem hiding this comment.
@tyzbit Yes I think it makes sense. As your previous commit entailed calling activeView which ends up pulling the command arg again and hence loading the context command again ;( Thank you for the fix!!
I do think a better solution would be to allow user to specify a default view in the k9s config directly aka defaultView as there are currently other places in the code which yields pod view as the default.
Merged
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
We want to switch to the command specified by the flag, but only at startup. Afterwards, we should be interactive and favor the user's command choices over the startup commandline switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to switch to the command specified by the flag, but only at startup.
Afterwards, we should be interactive and favor the user's command choices over the startup commandline switch.
Sidenote: I'm not very familiar with
k9s's codebase, so I didn't see any.Lock()I should be calling when updating the*Configobject or if updating via pointer is not advised. Give me a hint and I'll run from there 😎Bug introduced in #2045
Fixes #2085
cc: @kinoute (thank you for reporting this!)