Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

fix: made conf and context optional again #171

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

m4thieulavoie
Copy link
Contributor

@m4thieulavoie m4thieulavoie commented Jun 22, 2020

Just realized that the two last optional parameters are not optional anymore since the Typescript upgrade

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr. Since we're here, I believe the timeout parameter should also be optional. Would you mind updating that as well? If not then I can do it after this is merged.

@m4thieulavoie
Copy link
Contributor Author

Thanks for the pr. Since we're here, I believe the timeout parameter should also be optional. Would you mind updating that as well? If not then I can do it after this is merged.

Looking at IdleRequestOptions, I am not 100% certain timeout can be optional.

interface IdleRequestOptions {
    timeout: number;
}

Thoughts?

@straker
Copy link
Contributor

straker commented Jun 22, 2020

Hu. So the options parameter is optional but the timeout is required in it? Guess it can't be optional. Thanks for looking into it.

@straker straker merged commit 605cab8 into dequelabs:develop Jun 22, 2020
@m4thieulavoie m4thieulavoie deleted the fix/optional-parameters branch June 22, 2020 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants