Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): synced Link component #1675

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat(styles): synced Link component #1675

merged 8 commits into from
Sep 19, 2024

Conversation

orest-s
Copy link
Contributor

@orest-s orest-s commented Sep 16, 2024

Closes: #1672

@orest-s orest-s marked this pull request as ready for review September 16, 2024 16:20
@orest-s orest-s requested review from a team as code owners September 16, 2024 16:20
scurker
scurker requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to make one small tweak for the Button variant and see comment about line height.

e2e/screenshots/dark--link-variant-button-.png Outdated Show resolved Hide resolved
packages/styles/link.css Outdated Show resolved Hide resolved
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1675.d15792l1n26ww3.amplifyapp.com

scurker
scurker requested changes Sep 18, 2024
View reviewed changes
packages/react/src/components/Link/index.css Outdated Show resolved Hide resolved
e2e/screenshots/button-variant-link-.png Outdated Show resolved Hide resolved
@orest-s @scurker
Update packages/react/src/components/Link/index.css
d77298d 
Co-authored-by: Jason <jason@scurker.com>
scurker
scurker approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@orest-s orest-s merged commit 8ff3885 into develop Sep 19, 2024
8 checks passed
@orest-s orest-s deleted the fix/sync-design-link branch September 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Sync: Link
2 participants
@orest-s @scurker