feat(styles,react): added size prop to tag and synced with designs #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
scurker
requested changes
Jul 31, 2024
There was a problem hiding this comment.
This is missing tests for the new size (see https://github.com/dequelabs/cauldron/blob/develop/CONTRIBUTING.md#testing-strategies)
One other thing as well, can we make the existing <Tag> component in documentation here use the small size?
Co-authored-by: Jason <jason@scurker.com>
scurker
previously requested changes
Jul 31, 2024
scurker
reviewed
Jul 31, 2024
scurker
reviewed
Aug 1, 2024
There was a problem hiding this comment.
This should be feat as we are adding additional features and describe the changes, e.g. added size prop to tag and synced with designs. Additionally, I'm double checking with @dequelabs/cauldron-design so we can get a quick design review to ensure everything is kosher.
orest-s
changed the title
orest-s
changed the title
scurker
reviewed
Aug 1, 2024
scurker
reviewed
Aug 2, 2024
shawnsharpDQ
approved these changes
Aug 2, 2024
scurker
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1578