Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): switch dialog tests to react testing library and fix heading type #1501

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

scurker
Copy link
Member

@scurker scurker commented Jun 4, 2024

ref #1159
closes #140

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1501.d15792l1n26ww3.amplifyapp.com

@scurker scurker marked this pull request as ready for review June 11, 2024 20:51
@scurker scurker requested a review from a team as a code owner June 11, 2024 20:51
@scurker scurker requested a review from a team June 11, 2024 21:05
Copy link

@abhideo-deque abhideo-deque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@scurker scurker closed this Jun 12, 2024
@scurker scurker reopened this Jun 12, 2024
@scurker
Copy link
Member Author

scurker commented Jun 12, 2024

Looks like actions got stuck from yesterday, so closing/reopening to retrigger them.

@scurker scurker closed this Jun 12, 2024
@scurker scurker reopened this Jun 12, 2024
@scurker scurker requested a review from a team June 14, 2024 13:38
@scurker scurker merged commit 3b7a548 into develop Jun 18, 2024
8 checks passed
@scurker scurker deleted the dialog-tests branch June 18, 2024 21:07
Copy link
Collaborator

@thuey thuey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Modal heading prop should take text as a prop as well as JSX.Elements
3 participants