Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(invalidrole): allow upper and mixed case role names #4358

Merged
merged 7 commits into from
Apr 1, 2024
Merged

fix(invalidrole): allow upper and mixed case role names #4358

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9292f6
fix(invalidrole): add toLowerCase to the invalidrole check for role v…
lsprr Mar 5, 2024
a8473b6
Test: add cases to verify invalidrole behavior with empty and nonsens…
lsprr Mar 5, 2024
5fbdf06
Minor correction
lsprr Mar 5, 2024
f32a327
Merge branch 'develop' into invalidrole-evaluate
lsprr Mar 18, 2024
5196f19
Added test case for role validation: valid uppercase roles now return…
lsprr Mar 20, 2024
92fc033
Minor correction
lsprr Mar 21, 2024
53afb9a
Merge branch 'develop' into invalidrole-evaluate
lsprr Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checks/aria/invalidrole-evaluate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { tokenList } from '../../core/utils';
function invalidroleEvaluate(node, options, virtualNode) {
const allRoles = tokenList(virtualNode.attr('role'));
const allInvalid = allRoles.every(
role => !isValidRole(role, { allowAbstract: true })
role => !isValidRole(role.toLowerCase(), { allowAbstract: true })
);

/**
Expand Down
15 changes: 15 additions & 0 deletions test/checks/shared/invalidrole.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,19 @@ describe('invalidrole', function () {
);
assert.deepEqual(checkContext._data, ['foo', 'bar']);
});

it('should return true if applied to an uppercase nonsensical role', function () {
var virtualNode = queryFixture(
'<div id="target" role="FOO">Contents</div>'
lsprr marked this conversation as resolved.
Show resolved Hide resolved
);
assert.isTrue(
checks.invalidrole.evaluate.call(
checkContext,
virtualNode.actualNode,
null,
virtualNode
)
);
assert.deepEqual(checkContext._data, ['FOO']);
});
});