Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade npm to v6 and regenerate package-lock #3013

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 17, 2021

npm v7 causes a multitude of problems, namely that we can't run npm ci for the release script since it uses ssh protocol for all dependencies to read from it, which fails if you don't have ssh permissions.

 npm ci 
npm WARN prepare removing existing node_modules/ before installation
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/act-rules/act-rules.github.io.git
npm ERR!
npm ERR! git@github.com: Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR!
npm ERR! exited with error code: 128
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/stevenlambert/.npm/_logs/2021-06-17T15_33_48_646Z-debug.log

I had to downgrade to npm v6 and then delete package-lock.json and regenerate it to solve the issue.

See npm/cli#2610
See npm/cli#3284

This pr replaces #2996 and includes updated dependencies as well since i regenerated the package-lock file. I hate that we have to downgrade chromedriver from @latest to v90 as well, but CircleCI hasn't updated it's version of chrome to v91 and we really need this merged to do the release.

@straker straker requested a review from a team as a code owner June 17, 2021 17:12
@straker straker merged commit 607f688 into develop Jun 21, 2021
@straker straker deleted the downgrade branch June 21, 2021 14:20
straker added a commit that referenced this pull request Jun 22, 2021
* chore: downgrade npm to v6 and regenerate package-lock

* fix chromedriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants