feat/LS-20: 회고 템플릿 조회 API #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/LS-20
…into feat/LS-20
mikekks
reviewed
Jul 14, 2024
Comment on lines
11
to
13
| public interface TemplateQuestionRepository extends JpaRepository<TemplateQuestion, Long> { | ||
| List<TemplateQuestion> findByTemplateId(Long templateId); | ||
| } |
There was a problem hiding this comment.
기능적으로는 문제 없지만 findAllBy~로 하는건 어떠신가요??
Comment on lines
27
to
28
| Template template = templateRepository.findById(templateId).orElseThrow(() -> new TemplateException(TemplateExceptionType.TEMPLATE_NOT_FOUND)); | ||
| return TemplateSimpleInfoResponse.toResponse(template); |
There was a problem hiding this comment.
repo 쪽에 findByIdOrThrow 라는 default 메서드 만들어서 구현하는건 어떻게 생각하시나요?!
There was a problem hiding this comment.
또한 단건 조회가 아닌경우 findAll~ 로 하는건 어떠신가요??
There was a problem hiding this comment.
첫번째 리뷰에 말씀해주신 방식을 잘 몰라서 찾아봤는데, 이런식의 코드를 의미하시는게 맞으실까요??
import org.springframework.data.jpa.repository.JpaRepository;
import java.util.Optional;
public interface CustomJpaRepository<T, ID> extends JpaRepository<T, ID> {
default T findByIdOrThrow(ID id) {
return findById(id).orElseThrow(() -> new EntityNotFoundException("Entity with ID " + id + " not found"));
}
}There was a problem hiding this comment.
findByIdOrThrow로 변경하여 커밋했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 타입
📢 변경 사항
아래 4가지 api를 작성했습니다.
❗️To Reviewer
⚙️ 테스트 결과
캡처 사진 순서는 "변경 사항" 부분과 일치합니다!
👉 반영 브랜치