Skip to content
This repository has been archived by the owner on Apr 26, 2020. It is now read-only.

Added note about current bug with autoload #178

Merged
merged 2 commits into from
Apr 17, 2018

Conversation

XanderLuciano
Copy link
Contributor

@XanderLuciano XanderLuciano commented Apr 7, 2018

I added a note + temporary workaround for deployphp/deployer#1371 so that users don't have to waste time figuring out why this isn't working currently. This will be reverted hopefully once v7 is released with a fix.
I also added better examples to the configurations so that new users would know exactly how to use the commands.

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Do not forget to add notes about your changes to CHANGELOG.md

I added a note + temporary workaround for deployphp/deployer#1371 so that users don't have to waste time figuring out why this isn't working currently. This will be reverted hopefully once v7 is released with a fix.
I also added better examples to the configurations so that new users would know exactly how to use the commands.
@XanderLuciano
Copy link
Contributor Author

If you guys are cool with this PR I'd be happy to update the remain doc files (as well as reverting them after the next release).

@XanderLuciano
Copy link
Contributor Author

Any feedback?

docs/slack.md Outdated

```php
require 'recipe/slack.php';
//require 'recipe/slack.php';
require 'require 'vendor/deployer/recipe/recipes/slack.php';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require 'require?

removed extra 'required' which was a typo.
@XanderLuciano
Copy link
Contributor Author

Whoops, typo from copy / pasting. Good catch, updated PR with changes.

@antonmedv antonmedv merged commit be3d2f5 into deployphp:master Apr 17, 2018
@XanderLuciano XanderLuciano deleted the patch-1 branch April 17, 2018 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants