always recurse submodules when cloning #9278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I assume it'll fix this too? |
|
Yes I think so, the problem then was we weren't cloning for Gradle yet. Now that we're cloning and fetching submodules it should be fixed without additional changes 🤞 |
|
Awesome, can you please link it? I tried but wasn't successful :) |
|
Since it's a PR it can't be linked like issues can, I'll close it out and reference this PR once it's merged. |
abdulapopoola
approved these changes
Mar 13, 2024
jurre
approved these changes
Mar 13, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8933 we made all ecosystems clone rather than fetching single files.
Similarly this PR enables recurse submodules for all ecosystems to fix some path dependency issues. The only downside would be an increase in out of disk errors but we can onboard to Actions beta now which increases the amount of disk available.
Fixes #8428
Fixes #9198
Fixes #7201
Fixes #9193
Fixes #7916
Supersedes:
recurse_submodules_when_cloningtocargo#9181