Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface out of disk/memory error message for easier visibility #9064

Merged
merged 6 commits into from
Feb 17, 2024

Conversation

honeyankit
Copy link
Contributor

@honeyankit honeyankit commented Feb 16, 2024

Context

These currently end up in the unknown_error category so this provides easier visibility to the user.

  • Added out of disk error message to the go module updater.
  • Added out of disk/memory error message to the yarn file parser.

@honeyankit honeyankit self-assigned this Feb 16, 2024
@honeyankit honeyankit force-pushed the honeyankit/add-out-of-disk-error-message branch from 88f2328 to 11cc0d5 Compare February 16, 2024 19:50
@honeyankit honeyankit marked this pull request as ready for review February 16, 2024 21:21
@honeyankit honeyankit requested a review from a team as a code owner February 16, 2024 21:21
@jakecoffman
Copy link
Member

I'd bet the error message write fatal: sha1 file '/home/dependabot/dependabot-updater/repo/.git/index.lock' write error. is not coming from Go and Yarn CLIs, but our workspace/git.rb operations.

@honeyankit
Copy link
Contributor Author

honeyankit commented Feb 16, 2024

I'd bet the error message write fatal: sha1 file '/home/dependabot/dependabot-updater/repo/.git/index.lock' write error. is not coming from Go and Yarn CLIs, but our workspace/git.rb operations.

There are two errors in the sentry:
https://github.sentry.io/discover/deltaforce:b9cc2996e6104f6dbf95937df5aa4f68/?field=title&field=event.type&field=project&field=user.display&field=timestamp&field=replayId&homepage=true&name=All+Events&project=1451818&query=disk&sort=-timestamp&statsPeriod=90d&yAxis=count%28%29

One is from workspace/git.rb and another one from No space left on device @ io_write - yarn.lock. So is it the case that the issue is in workspace/git.rb and because of that yarn.lock is failing out of disk?

@jakecoffman
Copy link
Member

write fatal: sha1 file '/home/dependabot/dependabot-updater/repo/.git/index.lock' write error appears to be coming from workspace/git.rb so I would catch it there, it won't be coming from Go or Yarn code that won't fix the issue.

I agree that No space left on device @ io_write - yarn.lock is coming from the Yarn file parser, that looks good 👍

@abdulapopoola
Copy link
Member

abdulapopoola commented Feb 16, 2024

Tagging @bdragon since he has context on the git.rb file ; he might have some context on that file and it might be the true source of the failures as @jakecoffman pointed out.

@abdulapopoola
Copy link
Member

abdulapopoola commented Feb 16, 2024

Took a peek - it appears the source of the failure is the reset command

@honeyankit
Copy link
Contributor Author

honeyankit commented Feb 16, 2024

Took a peek - it appears the source of the failure is the reset command

Yes, but I want to add exception to the common place where run_shell_command is defined. In the git.rb, the run_shell_command is called by different git operations and adding it there will make more sense. I have already pushed the change, just adding test and we are good!

@honeyankit honeyankit changed the title Added out of disk error message to the go module updater Surface out of disk/memory error message for easier visibility Feb 16, 2024
@honeyankit honeyankit merged commit c676f59 into main Feb 17, 2024
140 checks passed
@honeyankit honeyankit deleted the honeyankit/add-out-of-disk-error-message branch February 17, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants