-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump PNPM from 8.3.1 to 8.6.4 #7330
Conversation
As always, thank you for these! FYI that internally we have a deploy freeze for the next few days. Once that ends, we'd prefer to avoid a big-bang release, so while we'll be merging docs changes and minor tweaks here and there, we're going to delay merging anything that bumps versions... That way when the freeze lifts we can have a smaller safer deploy, get a healthy baseline of metrics, then iteratively start merging the slightly riskier bumps and watching them in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to hold off merging this for a bit more, but going to approve so we know that it's good to go once we're ready
312a9e7
to
7b9b0da
Compare
b66fc86
to
ab877a8
Compare
I edited this PR to bump PNPM all the way to 8.6.3. The upgrade also fixes an issue specific to lockfiles generated with either PNPM 8.6.0 and 8.6.1. Those versions generated a lockfile format ( This will need some updates to smoke tests. |
Smoke tests failure should get fixed by dependabot/smoke-tests#82. |
ab877a8
to
ec556d8
Compare
@jurre You had already approved this but I added a few more changes on top of it, so I'll wait for a second review if that's ok 🙏. |
This PR fixes this error by the way! |
05b036f
to
94d061c
Compare
@deivid-rodriguez 8.6.4 was released a couple of hours ago and I just updated this PR |
Thank you! By the way this is the upstream issue for the problem with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
94d061c
to
0626056
Compare
See https://github.com/pnpm/pnpm/releases/tag/v8.6.4