Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo: handle unsupported toolchain versions #7122

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Cargo: handle unsupported toolchain versions #7122

merged 2 commits into from
Apr 20, 2023

Conversation

jakecoffman
Copy link
Member

Follow-up to #7066, this will display a helpful error when doing an update on a toolchain that is not supported by Dependabot.

@jakecoffman jakecoffman requested a review from a team as a code owner April 19, 2023 19:54
@github-actions github-actions bot added the L: rust:cargo Rust crates via cargo label Apr 19, 2023
jeffwidman
jeffwidman approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 to ship this as-is, although this may not fully protect against really old versions... 🤷‍♂️

That said, really old versions are probably a really low % of our users, as folks who lag that far on Rust are unlikely to be :dependabot: power users.

cargo/lib/dependabot/cargo/file_updater/lockfile_updater.rb Show resolved Hide resolved
@ilya-bobyr ilya-bobyr mentioned this pull request Apr 19, 2023
Closed
@jeffwidman jeffwidman mentioned this pull request Apr 19, 2023
Closed
@jeffwidman jeffwidman force-pushed the jakecoffman/error-on-older-toolchains branch from 9b39bbc to fe702d5 Compare April 20, 2023 06:24
@jeffwidman jeffwidman enabled auto-merge (squash) April 20, 2023 06:26
@jeffwidman jeffwidman merged commit c446d86 into main Apr 20, 2023
@jeffwidman jeffwidman deleted the jakecoffman/error-on-older-toolchains branch April 20, 2023 11:50
@jakecoffman jakecoffman mentioned this pull request Apr 25, 2023
Merged
jeffwidman pushed a commit that referenced this pull request Apr 25, 2023
@jakecoffman
Cargo: handle sparse registry in version resolver (#7168)
7436114 
This is the same PR as #7122 but against the version resolver. 

It would probably be good in the future to create a native helper that both the version resolver and lockfile updater use since the errors seem like they are the same between the two.
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@jakecoffman
Cargo: handle unsupported toolchain versions (dependabot#7122)
c201f13 
Follow-up to dependabot#7066, this will display a helpful error when doing an update on a toolchain that is not supported by Dependabot.
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@jakecoffman
Cargo: handle sparse registry in version resolver (dependabot#7168)
62d8fab 
This is the same PR as dependabot#7122 but against the version resolver. 

It would probably be good in the future to create a native helper that both the version resolver and lockfile updater use since the errors seem like they are the same between the two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
L: rust:cargo Rust crates via cargo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakecoffman @jeffwidman