Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(npm): explain situations where parsing resolved can fail #7106

Merged
merged 1 commit into from
Apr 18, 2023
Merged

docs(npm): explain situations where parsing resolved can fail #7106

merged 1 commit into from
Apr 18, 2023

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Apr 18, 2023

Follow up for the following discussion #7030 (comment)

@yeikel yeikel force-pushed the fix/skip-false branch 3 times, most recently from ac59649 to 9ce3f19 Compare April 18, 2023 02:54
@yeikel yeikel marked this pull request as ready for review April 18, 2023 02:58
@yeikel yeikel requested a review from a team as a code owner April 18, 2023 02:58
@yeikel yeikel mentioned this pull request Apr 18, 2023
Merged
jeffwidman
jeffwidman approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffwidman jeffwidman enabled auto-merge (squash) April 18, 2023 03:00
@jeffwidman jeffwidman merged commit 7dc0dac into dependabot:main Apr 18, 2023
@yeikel yeikel deleted the fix/skip-false branch April 18, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
L: javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeikel @jeffwidman