Re-enable two pending tests #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
remove-two-pending-markers
branch
from
89cdc99
to
94209ec
Compare
|
@jeffwidman Not sure if this is useful? deivid-rodriguez@ec4f8b6 Apparently I worked on this when first contributing to dependabot-core, but never followed up on it. |
jeffwidman
force-pushed
the
remove-two-pending-markers
branch
2 times, most recently
from
1e482f2
to
bdab181
Compare
jeffwidman
commented
Jan 23, 2023
jeffwidman
force-pushed
the
remove-two-pending-markers
branch
from
bdab181
to
767ccb0
Compare
Nishnha
approved these changes
Jan 24, 2023
Per the discussion in #3319 (comment), these only temporarily needed to be marked `pending` until #3327 was merged. From the first thread it looks like the intent was to remove the `pending` marker, but that accidentally got overlooked. So this removes the `pending` marker, and then fixes the failures: 1. The first was a straightforward change from method to hash value. 2. The second wasn't raising the expected error... However, this has been true since [this code was originally committed](https://github.com/dependabot/dependabot-core/pull/3319/files#r600526250) (once #3327 was merged to make the test work). So I deleted the test as it added no value.
jeffwidman
force-pushed
the
remove-two-pending-markers
branch
from
767ccb0
to
72404bf
Compare
Nishnha
approved these changes
Jan 24, 2023
deivid-rodriguez
approved these changes
Jan 24, 2023
alcere
pushed a commit
that referenced
this pull request
Feb 20, 2023
Per the discussion in #3319 (comment), these only temporarily needed to be marked `pending` until #3327 was merged. From the first thread it looks like the intent was to remove the `pending` marker, but that accidentally got overlooked. So this removes the `pending` marker, and then fixes the failures: 1. The first was a straightforward change from method to hash value. 2. The second wasn't raising the expected error... However, this has been true since [this code was originally committed](https://github.com/dependabot/dependabot-core/pull/3319/files#r600526250) (once #3327 was merged to make the test work). So I deleted the test as it added no value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #3319 (comment),
these only temporarily needed to be marked
pendinguntil#3327 was merged.
From the first thread it looks like the intent was to remove the
pendingmarker, but that accidentally got overlooked.So this removes the
pendingmarker, and then fixes the failures:been true since this code was originally committed
(once Bundler 2: [Prerelease] Implement v2 native functions for LatestVersionFinder #3327 was merged to make the test work). So I deleted the test
as it added no value.