Update NuGet to fetch packages using SemVer 2 #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
reviewed
Sep 23, 2021
| @@ -59,7 +59,7 @@ def build_url_for_details(repo_details) | |||
| end | |||
| if search_url | |||
| details[:search_url] = | |||
| search_url + "?q=#{dependency.name.downcase}&prerelease=true" | |||
| search_url + "?q=#{dependency.name.downcase}&prerelease=true&semVerLevel=2.0.0" | |||
There was a problem hiding this comment.
Would this still include semver level 1 releases?
There was a problem hiding this comment.
Yes it does
4.0.0 uses semver 1 while the versions > 5.6.1-pre1 use semver 2
Nishnha
force-pushed
the
nishnha/update-nuget-semver-2
branch
from
0d3dc6e to
df0be23
Compare
|
There's a VCR recording in the NuGet test suite causing the CI to fail on this PR. The recording is of fetching a package from a local Artifactory install. The original VCR fixture was recorded on Dependabot 0.149.5 -- do we know how to re-record this? |
This was referenced Feb 19, 2022
Also fixes string assignments to be object assignments for test setup
jurre
approved these changes
Mar 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot is currently failing to search/fetch NuGet packages using SemVer 2 versioning.
The API query we use for package versions seems to only fetch package versions using SemVer 1
For example, on https://www.nuget.org/packages/Xamarin.Forms/, the current version is
5.0.0.2125,but Dependabot's current query for NuGet packages, https://api-v2v3search-0.nuget.org/query?q=xamarin.forms&prerelease=true, only shows
4.x.xand lower releasesTo query for newer packages that use SemVer 2, we add
&semVerLevel=2.0.0to the query string:https://api-v2v3search-0.nuget.org/query?q=xamarin.forms&prerelease=true&semVerLevel=2.0.0 correctly shows the
5.x.xreleases.This PR also changes the server we use for NuGet queries.
https://api.nuget.org/v3/index.json returns a list of
SearchQueryServiceservers, and api-v2v3search-0.nuget.org is no longer on that list.The query server has been changed to azuresearch-usnc.nuget.org, which should return the same results as the previous server.