-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bin/ci-test #3959
bin/ci-test #3959
Conversation
Bless'ed be! |
before you shellwreck yourself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,57 @@ | |||
#!/bin/bash -e | |||
#/ usage: ci-test SUITE | |||
#/ simulate the process followed by ~/.github/workflows/ci.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -3,6 +3,7 @@ | |||
set -e | |||
|
|||
shellcheck \ | |||
./bin/ci-test \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I still don't like this solution: it's a hack, but a valuable one. 🩹 |
This brings back the helper added in #3398 . I'd re-written it for #3911 , then @Nishnha asked about the same thing.
The goal of this script is to replicate the build performed by Actions in CI, https://github.com/dependabot/dependabot-core/blob/main/.github/workflows/ci.yml by bypass remote Docker caching.
It's still not a good idea to have this build logic defined in two places; I just wanted feedback looks from Actions environment (which isn't quite the same as the development shell) without pushing.