Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/ci-test #3959

Merged
merged 2 commits into from
Jun 23, 2021
Merged

bin/ci-test #3959

merged 2 commits into from
Jun 23, 2021

Conversation

thepwagner
Copy link
Contributor

@thepwagner thepwagner commented Jun 21, 2021

This brings back the helper added in #3398 . I'd re-written it for #3911 , then @Nishnha asked about the same thing.

The goal of this script is to replicate the build performed by Actions in CI, https://github.com/dependabot/dependabot-core/blob/main/.github/workflows/ci.yml by bypass remote Docker caching.

It's still not a good idea to have this build logic defined in two places; I just wanted feedback looks from Actions environment (which isn't quite the same as the development shell) without pushing.

@thepwagner thepwagner requested a review from a team as a code owner June 21, 2021 19:31
@Nishnha
Copy link
Member

Nishnha commented Jun 21, 2021

Bless'ed be!

before you shellwreck yourself
Copy link
Contributor

@xlgmokha xlgmokha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -0,0 +1,57 @@
#!/bin/bash -e
#/ usage: ci-test SUITE
#/ simulate the process followed by ~/.github/workflows/ci.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -3,6 +3,7 @@
set -e

shellcheck \
./bin/ci-test \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thepwagner
Copy link
Contributor Author

I still don't like this solution: it's a hack, but a valuable one. 🩹 :shipit:

@thepwagner thepwagner merged commit 2c638b6 into main Jun 23, 2021
@thepwagner thepwagner deleted the bin-ci-test branch June 23, 2021 10:13
@thepwagner thepwagner mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants