Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the go directive to 1.16 #3578

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Bump the go directive to 1.16 #3578

merged 2 commits into from
Apr 28, 2021

Commits on Apr 28, 2021

  1. Cleanup go.mod handling of helpers 

    Since `go.mod` in the root of helpers declares itself as:
```
module github.com/dependabot/dependabot-core/go_modules/helpers
```

then my understanding is there's no need to have custom replace
directives... `go` is smart enough to realize that these are local pkgs
and should be imported locally.

As a result, we also no longer need a custom `go.mod` file within the
subpackage.

Which makes life easier as this subpackage declared an older version of
the extracted go modules repo... which works, but can be confusing since
there are two `go.mod` files with slightly different minimum supported
versions. Avoid all that by treating this as a package of the parent
modules rather than a standalone module.
    @jeffwidman
    jeffwidman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    dbae35d View commit details
    Browse the repository at this point in the history

  2. Bump the go directive to 1.16 

    This isn't strictly required, but it makes life simpler in some edge
cases... and also later someone is considering updating, it's easier if
this has been kept up to date all along so the delta is smaller down the
road.
    @jeffwidman
    jeffwidman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    be4675d View commit details
    Browse the repository at this point in the history