Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler: Add tests for bundler 2 resolution #3424

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

feelepxyz
Copy link
Contributor

Add UpdateChecker test cases for a gem that depends on a particular
version of bundler.

@feelepxyz feelepxyz requested a review from a team as a code owner April 1, 2021 09:09
@jurre
Copy link
Member

jurre commented Apr 1, 2021

Is this a duplicate of #3418?

@feelepxyz
Copy link
Contributor Author

@jurre oh sorry totally missed your PR! 🤦

Add UpdateChecker test cases for a gem that depends on a particular
version of bundler.
let(:dependency_name) { "guard-bundler" }
let(:current_version) { "2.2.1" }

context "using bundler v1", :buldler_v1_only do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops misspelt the key buldler_v1_only 😀

@feelepxyz feelepxyz force-pushed the feelepxyz-test-bundler2-resolution branch from 7cfb93c to e8eb8dc Compare April 1, 2021 09:36
@jurre
Copy link
Member

jurre commented Apr 1, 2021

@jurre oh sorry totally missed your PR! 🤦

No worries 😄 let's go with this one though 👍

@feelepxyz feelepxyz merged commit fb8e3d4 into main Apr 1, 2021
@feelepxyz feelepxyz deleted the feelepxyz-test-bundler2-resolution branch April 1, 2021 09:54
@thepwagner thepwagner mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants