Attempt to fix npm install timing out ci builds #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like npm installing the npm_and_yarn helpers is timing out a fair bit on ci: https://github.com/dependabot/dependabot-core/pull/3329/checks?check_run_id=2183869598 Seeing errors like: ``` npm ERR! code ERR_SOCKET_TIMEOUT npm ERR! errno ERR_SOCKET_TIMEOUT npm ERR! request to https://registry.npmjs.org/@jest/reporters/-/reporters-26.6.2.tgz failed, reason: Socket timeout ``` I also disabled `npm audit` when isntalling which we never look at from the build output.
feelepxyz
commented
Mar 24, 2021
npm_and_yarn/helpers/build
Outdated
| @@ -20,4 +20,4 @@ cp -r \ | |||
| "$install_dir" | |||
|
|
|||
| cd "$install_dir" | |||
| npm ci | |||
| npm ci --no-audit --fetch-timeout=600000 | |||
There was a problem hiding this comment.
Don't know if this will actually fix things, docs say the timeout is already 5 mins which I'm not sure is true from the build output. https://docs.npmjs.com/cli/v7/using-npm/config#fetch-timeout
There was a problem hiding this comment.
https://docs.npmjs.com/cli/v7/using-npm/config#fetch-retries seems interesting too - we may want to raise that from the default of 2.
There was a problem hiding this comment.
Yeah will try 5 and see if the build failure goes away 👍
thepwagner
approved these changes
Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like npm installing the npm_and_yarn helpers is timing out a fair
bit on ci:
https://github.com/dependabot/dependabot-core/pull/3329/checks?check_run_id=2183869598
Seeing errors like:
I also disabled
npm auditwhen isntalling which we never look at fromthe build output.