test: update assertions to pass #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepwagner
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
🎉
cc @feelepxyz I think this is an alternate method to the patch proposed in #3239
I think #3239 may be a more general fix, which I dig. But CI passes here, and I can't argue with a ✅ .
Agreed 👍 |
This was referenced Mar 8, 2021
jurre
added a commit
that referenced
this pull request
Mar 15, 2021
These tests run bundler to check the latest version, but any time this is updated the test would start to fail (#3235). This change makes sure that we only check that the version was unlocked by checking the major version only. If a v3 is ever released this will fail again, but at least it buys us a bit more time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
To unblock merging work into the default branch.
How was this fixed?
By updating the expected bundler version in the assertions
related to the failing tests.