Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gemspec sanitization bug when heredoc has methods chained onto it #3220

Merged

Commits on Mar 2, 2021

  1. Add a failing test to demonstrate gemspec sanitization bug

    Given a gemspec like this:
    
      Spec.new do |s|
        s.version = "0.1.0"
        s.post_install_message = <<~DESCRIPTION.strip.downcase
          My description
        DESCRIPTION
      end
    
    The sanitized output should look like this:
    
      Spec.new do |s|
        s.version = "0.1.0"
        "sanitized"
      end
    
    But it actually looks like this:
    
      Spec.new do |s|
        s.version = "0.1.0"
        "sanitized"
          My description
        DESCRIPTION
      end
    
    I'll look into a fix for this bug in a follow-up commit.
    jasonrudolph committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e25a21c View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Fix gemspec sanitization bug when heredoc has methods chained onto it

    Co-authored-by: Philip Harrison <feelepxyz@github.com>
    jasonrudolph and feelepxyz committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    8101b77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1a9fed View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Merge remote-tracking branch 'origin/main' into gracefully-handle-gem…

    …specs-with-heredocs-with-method-chains
    xlgmokha committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    d54e24e View commit details
    Browse the repository at this point in the history