Refactor npm 6 specs #3072
Merged
Refactor npm 6 specs #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
commented
Feb 3, 2021
| @@ -0,0 +1,6 @@ | |||
| const conflictingDependencyParser = require("./conflicting-dependency-parser"); | |||
There was a problem hiding this comment.
Shared between npm 6 and 7
feelepxyz
commented
Feb 3, 2021
| @@ -1683,70 +1614,30 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "errors" do | |||
| context "git sub-dependency with invalid from" do | |||
There was a problem hiding this comment.
Moved to the npm lockfile updater spec
feelepxyz
commented
Feb 4, 2021
| @@ -1590,35 +1311,18 @@ | |||
| ) | |||
| ).to eq("^3.0.2") | |||
| end | |||
|
|
|||
| context "for an npm6 lockfile" do | |||
There was a problem hiding this comment.
Seems identical to the above npm6/simple test case
jurre
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out the npm 6 spec refactors from #3011 to make it easier to review.
I've also made the change to install npm 7 cli but this is still unused.