Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorbet type checking to bundler/file_updater/gemspec_sanitizer.rb #11401

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amazimbe
Copy link
Contributor

What are you trying to accomplish?

Add sorbet type checking to bundler/file_updater/gemspec_sanitizer.rb

How will you know you've accomplished your goal?

Tests on CI should remain green and no new issues should appear in Sentry

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Jan 24, 2025
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Jan 24, 2025
@amazimbe amazimbe force-pushed the amazimbe/add-sorbet-to-gemspec-sanitizer.rb branch from 21bb842 to 0ee8eaf Compare January 24, 2025 15:52
@amazimbe amazimbe marked this pull request as ready for review January 24, 2025 16:16
@amazimbe amazimbe requested a review from a team as a code owner January 24, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants