Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report private_source_authentication_failure during fetch #11394

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Jan 23, 2025

The NuGet updater can raise a PrivateSourceAuthentication error during a fetch operation. This PR adds that error to the list of known errors in the fetcher_error_details function.

@brettfo brettfo requested a review from a team as a code owner January 23, 2025 20:41
@brettfo brettfo force-pushed the dev/brettfo/report-auth-error-during-fetch branch from e086764 to 84a6220 Compare January 24, 2025 00:08
Copy link
Member

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok to add error type and the source file in error message. I approve it.

@randhircs randhircs force-pushed the dev/brettfo/report-auth-error-during-fetch branch from 84a6220 to 99c445d Compare January 24, 2025 17:46
@randhircs randhircs merged commit ff79c04 into main Jan 24, 2025
128 checks passed
@randhircs randhircs deleted the dev/brettfo/report-auth-error-during-fetch branch January 24, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants