-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat -pre
version suffix as prerelease.
#10207
Conversation
Thanks a lot @dbrant , could you please add a test and we can get this over the line :) |
whoops, of course -- how about now? |
Merged and deployed! Thanks @dbrant !! |
For what it's worth, we discussed this in the past at #6747 and decided not to deviate from what Funny enough, when we rejected adding "-preview", I actually mentioned "-pre" explicitly:
|
Well, it was not really a clear decision, I totally understand taking the pragmatic approach over the correct, consistent one. Just saying that if we decide to do this, we may also want to reopen #6747. |
@jonjanego Thanks for the note, and no worries -- it looks like we'll need to convince the MapLibre developers to adopt more standard prerelease versions instead. |
What are you trying to accomplish?
Certain projects release packages with pre-release versions that have a suffix of
-pre
N, which doesn't seem to get caught by dependabot as a prerelease, and gets submitted in a pull request as a stable package.example prerelease:
https://github.com/maplibre/maplibre-native/releases/tag/android-v11.0.2-pre0
example erroneous pull request:
wikimedia/apps-android-wikipedia#4806