Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build-system.requires in pyproject.toml #8465

Open
1 task done
Harmon758 opened this issue Nov 27, 2023 · 4 comments
Open
1 task done

Support build-system.requires in pyproject.toml #8465

Harmon758 opened this issue Nov 27, 2023 · 4 comments
Labels
T: feature-request Requests for new features

Comments

@Harmon758
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Feature description

Discussed in #3290, which only added support for project.dependencies and project.optional-dependencies for initial pyproject.toml support (#5661).

@Harmon758 Harmon758 added the T: feature-request Requests for new features label Nov 27, 2023
lukpueh added a commit to lukpueh/tuf that referenced this issue Dec 13, 2023
Dependabot does not support `build-system.requires`. To get
reproducibility and auto-updates, we pin the version in a regular
requirements file and use it as constraint during build.

fixes: theupdateframework#2529
upstream issue: dependabot/dependabot-core#8465
h/t @jku
lukpueh added a commit to lukpueh/tuf that referenced this issue Dec 13, 2023
Dependabot does not support `build-system.requires`. To get
reproducibility and auto-updates, we pin the version in a regular
requirements file and use it as constraint during build.

fixes: theupdateframework#2529
upstream issue: dependabot/dependabot-core#8465
h/t @jku

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@edgarrmondragon
Copy link

This would be great to avoid clunky workarounds like theupdateframework/python-tuf@dd9b5e0.

@potiuk
Copy link

potiuk commented Oct 12, 2024

It would be great to have that in dependabot. Apache Airlfow uses "build-system.requires" with custom "failing canary build" approach - but having a dependabot create pull request for that would be great.

Is there any way Airflow committers can help with that ? Are there any issues with this support ? If not I might try to advocate for someone from our team to contribute it to dependabot.

@edgarrmondragon
Copy link

Should this have been closed by #10899 being merged?

@potiuk
Copy link

potiuk commented Jan 18, 2025

Yep. I can confirm it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

3 participants