-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple gemfiles #375
Comments
Slightly absurdly, the answer is "yes on the backend, no on the frontend". We've never figured out a good way to display information about which directory (or files) within a project an update setup is targeting, so while the backend supports have multiple update setups of the same language for the same project, there's no way to add them in the frontend. If you've got a particular repo in mind, let me know and I'll take a look at whether I can get things set up manually on our side. |
From @deivid-rodriguez on November 21, 2017 0:5
I think mentioning the specific gemfile being updated in the description & body of PR's could be enough? Like "Bump <gem_name> from <old_version> to <new_version> in <path_to_gemfile>"?
Yes, this one: https://github.com/activeadmin/activeadmin! Dependabot would need to open PR's to keep the |
OK, that links in with the work I'm doing on https://github.com/dependabot/feedback/issues/27 and #135 - will take a few days but I'll have something for you relatively soon. And I'd love to have Dependabot running on https://github.com/activeadmin/activeadmin so doubly motivated to get it done! |
From @deivid-rodriguez on November 21, 2017 0:17 Thanks @greysteil, let me know if you need anything from our side! ❤️ |
@deivid-rodriguez - I've been thinking about this one for a bit:
|
From @deivid-rodriguez on November 30, 2017 14:54 👋 @greysteil! So if I'm understanding this right, connecting @dependabot at this point would mean getting automatic updates for |
Yep, that's exactly right 🙂 |
From @deivid-rodriguez on November 30, 2017 15:1 Nice! I'll propose it to the team then. Definitely a 👍 from me! :) |
From @deivid-rodriguez on January 25, 2018 1:2 @greysteil Sorry I never updated this. The other activeadmin collaborators (who are more actively collaborating than me) had no interest on adding this, so that's why we didn't add it. Hopefully the changes you added will be useful to other projects, and I'll be able to convince AA folks one day :) |
No worries - it was useful feedback regardless! |
@greysteil I'm reconsidering this again, and I'm thinking... Since you can currently choose the root folder for your repo... Maybe having a structure like this and having separate checks with a different root for each Gemfile would work?
|
Tried the idea on my activeadmin fork. It kind of worked, but since the |
* Allow dependabot to look for prod/Gemfile See dependabot/dependabot-core#375 * Allow testing rails upgrade with working installation
Have there been updates on this? I have Gem with multiple Gemfiles that I'm trying to setup on GH. I've setup the Gemfiles like this in the repo, but haven't been able to get dependabot do scan them all.
|
We ended up going with the solution I proposed earlier for activeadmin, and it has worked fine for us since our dependencies are essentially automanaged now. It's quite noisy though, it'd be good to group the updates of the same dependency accross multiple gemfiles together. But it works for me! |
From @deivid-rodriguez on November 19, 2017 18:44
Some projects use multiple gemfiles. The main use case I know for this is to be able to test libraries against different major versions of dependencies.
Does dependabot support this kind of setups?
Copied from original issue: dependabot/feedback#51
The text was updated successfully, but these errors were encountered: