Merge pull request #3337 from dependabot/feelepxyz/fix-flaky-npm-spec

Fix flaky npm spec by checking requirements array
dependabot · Mar 24, 2021 · 742dc57 · 742dc57
2 parents f815cb3 + cbc9d1c
commit 742dc57
Showing 1 changed file with 22 additions and 34 deletions.
diff --git a/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/version_resolver_spec.rb b/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/version_resolver_spec.rb
@@ -1322,44 +1322,32 @@
         resolved_dependencies = resolver.dependency_updates_from_full_unlock
         react = resolved_dependencies.find { |d| d[:dependency].name == "react" }
         react_dom = resolved_dependencies.find { |d| d[:dependency].name == "react-dom" }
-        expect(react[:dependency].to_h).to eq(
+        expect(react[:dependency].requirements).to contain_exactly(
           {
-            "name" => "react",
-            "requirements" => [
-              {
-                file: "packages/package1/package.json",
-                requirement: "15.6.2",
-                groups: ["dependencies"],
-                source: nil
-              },
-              {
-                file: "packages/package2/package.json",
-                requirement: "15.6.2",
-                groups: ["dependencies"],
-                source: nil
-              }
-            ],
-            "package_manager" => "npm_and_yarn"
+            file: "packages/package1/package.json",
+            requirement: "15.6.2",
+            groups: ["dependencies"],
+            source: nil
+          },
+          {
+            file: "packages/package2/package.json",
+            requirement: "15.6.2",
+            groups: ["dependencies"],
+            source: nil
           }
         )
-        expect(react_dom[:dependency].to_h).to eq(
+        expect(react_dom[:dependency].requirements).to contain_exactly(
           {
-            "name" => "react-dom",
-            "requirements" => [
-              {
-                requirement: "15.6.2",
-                file: "packages/package2/package.json",
-                groups: ["dependencies"],
-                source: nil
-              },
-              {
-                requirement: "15.6.2",
-                file: "packages/package1/package.json",
-                groups: ["dependencies"],
-                source: nil
-              }
-            ],
-            "package_manager" => "npm_and_yarn"
+            requirement: "15.6.2",
+            file: "packages/package2/package.json",
+            groups: ["dependencies"],
+            source: nil
+          },
+          {
+            requirement: "15.6.2",
+            file: "packages/package1/package.json",
+            groups: ["dependencies"],
+            source: nil
           }
         )
       end