-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
letter and documents landing page styling #34626
base: main
Are you sure you want to change the base?
letter and documents landing page styling #34626
Conversation
@@ -220,3 +220,7 @@ label + div { | |||
.bullet-disc { | |||
list-style-type: disc; | |||
} | |||
|
|||
.address-section { | |||
line-height: 2.5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just going to "talk out" my thoughts around this line spacing - it looks huge on the page. The figma for this section looks like it has smaller line spacing. However, the example in the Figma showing the AE Design Patterns version does also have quite a large line height. So I think if we are going off of that, this should be fine? I sort of want to tag in @sh0wn and get his thoughts on the line height on the screenshot (if you haven't run it by him already).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed an updated with spacing signed off by @sh0wn
{toggleValue => | ||
toggleValue ? null : ( | ||
<> | ||
{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the empty space here? I'm just curious 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team#102845
Testing done
Tested locally
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Letters page
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?