Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letter and documents landing page styling #34626

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

janechodance
Copy link
Contributor

@janechodance janechodance commented Feb 11, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

department-of-veterans-affairs/va.gov-team#102845

Testing done

Tested locally

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop
Screenshot 2025-02-11 at 4 53 35 PM
  |   

Screenshot 2025-02-13 at 4 25 58 PM

|

What areas of the site does it impact?

Letters page

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@@ -220,3 +220,7 @@ label + div {
.bullet-disc {
list-style-type: disc;
}

.address-section {
line-height: 2.5;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going to "talk out" my thoughts around this line spacing - it looks huge on the page. The figma for this section looks like it has smaller line spacing. However, the example in the Figma showing the AE Design Patterns version does also have quite a large line height. So I think if we are going off of that, this should be fine? I sort of want to tag in @sh0wn and get his thoughts on the line height on the screenshot (if you haven't run it by him already).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed an updated with spacing signed off by @sh0wn

iandonovan
iandonovan previously approved these changes Feb 12, 2025
{toggleValue =>
toggleValue ? null : (
<>
{' '}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the empty space here? I'm just curious 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

dysbo
dysbo previously approved these changes Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update letter page address section and landing page design
4 participants