Travel Pay / update address handling and alert content

[liztownd]

Are you removing, renaming or moving a folder in this PR?

• No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
• Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

• No
• Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

• (Summarize the changes that have been made to the platform)

  • Updating the address handling to only check for residentialAddress (not having a mailingAddress fallback)
  • Updating the alert content for if a user doesn't have a home address on file
  • Updating unit tests

• (Which team do you work for, does your team own the maintenance of this component?)

• Travel Pay

Related issue(s)

• Link to ticket created in va.gov-team repo
  #102698

• Link to epic if not included in ticket
  #83829

Testing done

• Describe what the old behavior was prior to the change
• The code would first check if residentialAddress was present in the user's profile, then fall back to the mailingAddress, if neither was present an alert would show stating that we needed the user's address. Now, we only check for residentialAddress, and the content for the alert was updated to point a user to update their address in their profile.
• Describe the steps required to verify your changes are working as expected
• Running locally, change the user response to the noAddressUser in the /services/mocks/index.js file and run with the mock api. The alert should show a link to the profile/contact-information page for the user to update their profile.
• Describe the tests completed and the results
• updated unit tests to only check for residentialAddress and that the alert content had been updated
• Ran locally and checked visually that the alert was appearing as expected
• _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
• Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

	Before	After
Mobile
Desktop

What areas of the site does it impact?

Travel Pay

Acceptance criteria

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user