Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introduction page #34620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ToddWebDev
Copy link
Contributor

@ToddWebDev ToddWebDev commented Feb 11, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes

Did you change site-wide styles, platform utilities or other infrastructure?

  • No
  • Yes

Summary

Update the introduction page on the Pension Benefits form (21P-527EZ)

Issue

Design Reference

Go to Figma

Associated Pull Request(s)

n/a

How to run in local environment

  1. Check out this branch locally
  2. Run vets-website and vets-api
  3. In your local environment, set the pension_introduction_update flipper to 'enabled' at http://localhost:3000/flipper/features/pension_introduction_update
  4. Go to http://localhost:3001/pension/apply-for-veteran-pension-form-21p-527ez/ in your browser

How to verify

  1. Verify the requested copy changes are visible on the introduction page

What areas of the site does it impact?

Pension Benefits Application

Screenshots

Desktop

Before After
localhost_3001_pension_apply-for-veteran-pension-form-21p-527ez_introduction localhost_3001_pension_apply-for-veteran-pension-form-21p-527ez_

Quality Assurance & Testing

  • New unit tests (if applicable)
  • New E2E tests added (if applicable)
  • Existing unit tests and integration tests are passing
  • Existing E2E tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot style, layout and content matches the design references
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@ToddWebDev ToddWebDev added the pension-benefits Label used for Pull Requests/Issues that impact Pension Claims claims (CH36, 25-8832) label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pension-benefits Label used for Pull Requests/Issues that impact Pension Claims claims (CH36, 25-8832)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant