New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing service branches to service records schema #34611

Draft

ConnorJeff wants to merge 1 commit into main from MBMS-85215-Story/PreNeedIntServiceBranches

+42 −0

Contributor

ConnorJeff commented Feb 11, 2025 •

edited

Loading

Summary

Service Records did not have the most up to date list of service branches

Related issue(s)

Jira Ticket: https://jira.devops.va.gov/browse/MBMS-85215
Vets-api PR: MBMS-85215 Updated backend service labels to match pre need front end vets-api#20664

Testing done

What areas of the site does it impact?

Pre Need Integration Service Records.

Acceptance criteria

Ensure branches on the backend match the front end.
Update the following Service Branches to ensure they appear on the front-end:

Click to see list of service branches

```
  'XG' => 'Coast Guard Reserve',
```

  'AD' => 'U.S. Army Signal Corps Aero Div',

```
  'AS' => 'U.S. Army Air Service',
```

  'AV' => 'U.S. Army Signal Corps Avn Sec',

```
  'CW' => 'U.S. Civ of Afs WWI',
```
```
  'DT' => 'Dietitian World War I',
```
```
  'FC' => 'Engineer Field Clerk WWI',
```
```
  'IR' => 'Irregular Forces Laos',
```
```
  'NC' => 'Army Nurse Corps',
```
```
  'O1' => 'Confederate States Army',
```

  'O2' => 'Prov Army Confederate States',

```
  'O3' => 'Confederate States Navy',
```

  'O4' => 'Prov Navy Confederate States',

  'O5' => 'Confederate States Mar Corps',

  'O6' => 'Prov Mar Corps Confederate St',

```
  'OA' => 'Army Corps',
```
```
  'OB' => 'Artillery',
```
```
  'OC' => 'Battalion',
```
```
  'OD' => 'Battery',
```
```
  'OE' => 'Cavalry',
```
```
  'OF' => 'Commissary of Substance',
```
```
  'OH' => 'Division Hospital',
```
```
  'OI' => 'General Hospital',
```
```
  'OJ' => 'Infantry',
```
```
  'OK' => 'Regiment',
```
```
  'OL' => 'Regimental Hospital',
```
```
  'ON' => 'Veteran Reserve Corps',
```
```
  'OP' => 'Volunteers',
```

  'OR' => 'U.S. Revenue Cutter Service',

```
  'OT' => 'U.S. Cld Troops',
```
```
  'OU' => 'Continental Line',
```
```
  'OV' => 'Continental Navy',
```
```
  'OW' => 'Continental Marine',
```
```
  'OX' => 'Provisional Army',
```
```
  'OY' => 'Provisional Navy',
```
```
  'OZ' => 'Provisional Marine Regt',
```

  'QC' => 'Quartermstr Corp Female Clerk',

```
  'RA' => 'Reconstruction Aide',
```
```
  'RR' => 'Russian Railway Service',
```
```
  'SA' => 'U.S. Space Force',
```
```
  'SF' => 'Signal Corps Tel Oper',
```

  'SP' => 'Special Guerilla Unit Laos',

```
  'UT' => 'Utah Territorial Militia'
```


          Added missing service branches to service records schema

e17f4d9

jordanBoardmanCodes approved these changes

View reviewed changes

Contributor

jordanBoardmanCodes left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet