VACMS-19412-Reporting accessibility violations in a PR comment #19625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
…-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
|
Checking composer.lock changes... |
|
Accessibility Violations Found: [
{
"route": "/test-data-et",
"id": "button-name",
"impact": "critical",
"tags": [
"cat.name-role-value",
"wcag2a",
"wcag412",
"section508",
"section508.22.a",
"ACT",
"TTv5",
"TT6.a"
],
"description": "Ensures buttons have discernible text",
"help": "Buttons must have discernible text",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.7/button-name?application=axeAPI",
"nodes": [
{
"any": [
{
"id": "button-has-visible-text",
"data": null,
"relatedNodes": [],
"impact": "critical",
"message": "Element does not have inner text that is visible to screen readers"
},
{
"id": "aria-label",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-label attribute does not exist or is empty"
},
{
"id": "aria-labelledby",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
},
{
"id": "non-empty-title",
"data": {
"messageKey": "noAttr"
},
"relatedNodes": [],
"impact": "serious",
"message": "Element has no title attribute"
},
{
"id": "presentational-role",
"data": null,
"relatedNodes": [],
"impact": "minor",
"message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Page introduction' field\" data-proofing-help=\"Add an introduction that helps visitors understand if information on the page is relevant to them.\">
<span aria-hidden=\"true\">i</span>
</button>",
"target": [
".field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role=\"tooltip\"]"
],
"failureSummary": "Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
},
{
"any": [
{
"id": "button-has-visible-text",
"data": null,
"relatedNodes": [],
"impact": "critical",
"message": "Element does not have inner text that is visible to screen readers"
},
{
"id": "aria-label",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-label attribute does not exist or is empty"
},
{
"id": "aria-labelledby",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
},
{
"id": "non-empty-title",
"data": {
"messageKey": "noAttr"
},
"relatedNodes": [],
"impact": "serious",
"message": "Element has no title attribute"
},
{
"id": "presentational-role",
"data": null,
"relatedNodes": [],
"impact": "minor",
"message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Generate a table of contents from major headings' field\" data-proofing-help=\"By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.\">",
"target": [
".field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role=\"tooltip\"]"
],
"failureSummary": "Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
},
{
"any": [
{
"id": "button-has-visible-text",
"data": null,
"relatedNodes": [],
"impact": "critical",
"message": "Element does not have inner text that is visible to screen readers"
},
{
"id": "aria-label",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-label attribute does not exist or is empty"
},
{
"id": "aria-labelledby",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
},
{
"id": "non-empty-title",
"data": {
"messageKey": "noAttr"
},
"relatedNodes": [],
"impact": "serious",
"message": "Element has no title attribute"
},
{
"id": "presentational-role",
"data": null,
"relatedNodes": [],
"impact": "minor",
"message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Main content' field\" data-proofing-help=\"The main body of the page, which appears below the featured content.\">
<span aria-hidden=\"true\">i</span>
</button>",
"target": [
"button[data-proofing-help-title=\"About 'Main content' field\"]"
],
"failureSummary": "Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
]
}
] |
timcosgrove
approved these changes
Nov 1, 2024
| }); | ||
| }, | ||
| // Don't fail tests now that violations are reported in PR comments | ||
| skipFailures |
There was a problem hiding this comment.
Confirming this is the only actual change; everything else looks like reformatting.
There was a problem hiding this comment.
Yes, it's all reformatting except for the definition of skipFailures and passing that in the checkA11y function. This just makes it so that accessibility violations are logged instead of explicitly failing cypress tests.
keisterj-oddball
deleted the
VACMS-19412-comprehensive-test-plan-dump-the-cypress_accessibility_violationsjson-file-into-the-pr-after-cypress-tests-have-run-in-tugboat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing accessibility reporting
Relates to #19412 . (or closes?)
Testing done
Screenshots
QA steps
What needs to be checked to prove this works?
cypress_accessbility_violations.jsonfile from the tugboat instance.What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As user uid with user_role
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated PublishingIs this PR blocked by another PR?
DO NOT MERGEDoes this PR need review from a Product Owner
Needs PO reviewCMS user-facing announcement
Is an announcement needed to let editors know of this change?