bug/9253-Chika-ScreenViewTypeInstantlyRequestReview

[cadibemma]

Description of Change

• Discovered that currently 50% of our in app review events will ask for users to leave a review before they've managed to fully review the screen they've navigated too, almost certainly resulting in an automatic dismissal and invalidating a good amount of our attempts for in-app-reviews.

Screenshots/Video

Testing

• Tested on iOS
• Tested on Android

Reviewer Validations

• Screenview events that contribute to the in-app review counter only increment the counter if they would NOT result in a review surfacing. In other words, screenview events should never result in a review surfacing to Veterans.

PR Checklist

Reviewer: Confirm the items below as you review

• PR is connected to issue(s)
• Tests are included to cover this change (when possible)
• No magic strings (All string unions follow the Union -> Constant type pattern)
• No secrets or API keys are checked in
• All imports are absolute (no relative imports)
• New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

[dumathane]

Nailed it @cadibemma ! Good work.