Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/9583-EnableSSOAppWide #9673

Open
wants to merge 68 commits into
base: develop
Choose a base branch
from
Open

Conversation

theodur
Copy link
Contributor

@theodur theodur commented Sep 24, 2024

Description of Change

Enables SSO in applicable places throughout the app:

  • NotificationSettingsScreen
  • AppointmentCancelReschedule
  • NeedHelpData

Screenshots/Video

AppointmentCancelReschedule
Appointment.Schedule.After.webm
NeedHelpData
Claims.and.appeals.After.webm
NotificationSettingsScreen
Notifications.After.webm

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@theodur theodur marked this pull request as ready for review October 8, 2024 04:35
@theodur theodur requested review from a team as code owners October 8, 2024 04:35
@theodur theodur requested review from timwright12, alexandec, dumathane, cadibemma and Sparowhawk and removed request for a team October 8, 2024 04:35
Base automatically changed from feature/9286-SingleSignOn to develop October 8, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants