Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU/7433-Dylan-AuthMigration #8192

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

CU/7433-Dylan-AuthMigration #8192

wants to merge 37 commits into from

Conversation

Sparowhawk
Copy link
Contributor

@Sparowhawk Sparowhawk commented Mar 15, 2024 •
edited
Loading

Description of Change

Migrate auth slice to RQ, also untangled a lot of code that made several other files interdependent on authSlice

Screenshots/Video

N/A

Testing

Yarn test

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Migrate Auth slice to RQ, functionality should remain the same

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@Sparowhawk Sparowhawk changed the title first steps CU/7433-Dylan-AuthMigration Mar 21, 2024
@Sparowhawk Sparowhawk marked this pull request as ready for review March 21, 2024 15:28
@Sparowhawk Sparowhawk requested review from a team as code owners March 21, 2024 15:28
@dumathane dumathane added the Blocked - FE Ticket is blocked by front end eng dependency label Apr 12, 2024
@timwright12
Copy link
Contributor

@Sparowhawk should we pull FE-Needs-review off this if it's blocked?

@Sparowhawk Sparowhawk removed the Blocked - FE Ticket is blocked by front end eng dependency label Jul 23, 2024
@Sparowhawk
Copy link
Contributor Author

@timwright12 This one isn't blocked anymore. @theodur and the global team will be taking this one over. They are just prioritizing the Notification Migration one first

@timwright12
Copy link
Contributor

@Sparowhawk perfect, thank you!

@dumathane dumathane added the hold label Sep 16, 2024
@Sparowhawk Sparowhawk removed the hold label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sparowhawk @timwright12 @alexandec @dumathane @theodur