iOS ScrollView scroll bar position fix #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 15, 2021
ghost
approved these changes
Mar 15, 2021
jmarchi
approved these changes
Mar 15, 2021
lexicalninja
approved these changes
Mar 15, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
On iOS, the scrollbar from the ScrollView component would occasionally render in the center of the screen. This seems to be a bug with react native, and issue about this can be found here: facebook/react-native#26610
We can fix this by forcing a default scroll bar position on iOS
Original issue(s)
department-of-veterans-affairs/va.gov-team#21450
Screenshots
Before:
After:
Testing Considerations
Reviewers