Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint fixer #4853

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

sigmavirus24
Copy link
Contributor

Closes #4616

@sigmavirus24 sigmavirus24 force-pushed the bug/4616 branch 9 times, most recently from 0f77b0e to b083852 Compare November 17, 2024 19:23
@sigmavirus24 sigmavirus24 force-pushed the bug/4616 branch 2 times, most recently from 86b8e84 to ac4ba4b Compare November 24, 2024 12:31
@sigmavirus24 sigmavirus24 marked this pull request as ready for review November 24, 2024 12:31
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test.

autoload/ale/fixers/golangci_lint.vim Outdated Show resolved Hide resolved
test/fixers/test_golangci_lint_fixer_callback.vader Outdated Show resolved Hide resolved
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@hsanson hsanson merged commit 65b49c1 into dense-analysis:master Nov 27, 2024
7 checks passed
@sigmavirus24
Copy link
Contributor Author

Thanks for accepting this and helping work through it. This is my first vim plug-in contribution ever

@sigmavirus24 sigmavirus24 deleted the bug/4616 branch November 27, 2024 14:23
axhav pushed a commit to axhav/ale that referenced this pull request Dec 18, 2024
hsanson pushed a commit that referenced this pull request Dec 29, 2024
* Added jq support

Cleaned up yq.vim file

* Updated docs

* Updated supported-tools.md

* Added yq tests

* Fix python linting/formatting error when in virtual environment (#4865)

Python fixers and linters were failing when vim is running in a virtual
environment that's located in a path containing text `poetry`. The cause
of this was the regular expression `poetry\|pipenv\|uv$` which matches
`poetry` and `pipenv` if they appear anywhere in the virtualenv path.

* Add cljfmt fixer for clojure files (#4860)

* When using `actionlint` look for & use a config file (#4858)

Actionlint supports a config file and it lives in a very searchable
path, as the only files it acts on are in the `.github` directory
already.

Look for an `actionlint.yml` and `.yaml` in that path, and use the
config if its there.

* Fix linting with jq (#4765) (#4862)

With the 1.6 version of jq the error message start with "parse error".
With the last version of jq the error message start with "jq: parse error".
Fix it by using a regular expression that works in both cases.

* Properly handle optional end_line_no/end_line_pos in sqlfluff (#4867)

end_line_no/end_line_pos are optional. Example SQL:
`SELECT NULL FROM {{ a_jinja_templated_table }};`

`sqlfluff lint --dialect ansi --format json` gives the following error
among others:
```
{"start_line_no": 1, "start_line_pos": 21, "code": "TMP", "description":
"Undefined jinja template variable: 'a_jinja_templated_table'", "name":
"", "warning": false}
```

As one can see there is no end_line_no/end_line_pos.

* Add golangci-lint fixer (#4853)

Closes #4616

* Fixed copy-paste misstakes and added filter to docs

* Added test vader file for yq

* Fixed and updated the test case

---------

Co-authored-by: Walter Kaunda <14844142+kwalter94@users.noreply.github.com>
Co-authored-by: rudolf ordoyne <49649789+casens5@users.noreply.github.com>
Co-authored-by: Bea Hughes <108035665+beahues@users.noreply.github.com>
Co-authored-by: benjos1234 <legrimlvl24@gmail.com>
Co-authored-by: Coacher <Coacher@users.noreply.github.com>
Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fixer for golangci-lint
2 participants