Implement listing all returned results for LSP textDocument/implements #4755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the intention of implementing the list feature for
:ALEGoToDefinition
and:ALEGoToImplementation
. Specially:ALEGoToImplementation
. There are times a LSP may return multiple results for thetextDocument/implementation
command. This is true when we try to find implementations of an abstract class or interface. The way ALE is implemented, only the first result is returned.Take this example.
foobar.go:
foobar_a.go
another_foobar.go
When trying to find implementations of the
Do
function, it will only find the one fromAnotherFoobar
struct (because the LSP returns in alphabetic order). But I could want the other one. This change fixes this behavior.