Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in sqlfluff implementation & implement fixer support #4365

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

carlsmedstad
Copy link
Contributor

Made a mistake in my initial implementation that is corrected here.

Also added support for using sqlfluff as a fixer.

Avoid crashes when there isn't any output from sqlfluff.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks .

@hsanson hsanson merged commit 5903523 into dense-analysis:master Nov 23, 2022
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
…nalysis#4365)

* Account for no sqlfluff output

Avoid crashes when there isn't any output from sqlfluff.

* Add supplort for sqlfluff as a fixer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants