Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft's DSL Bicep #4310

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

carlsmedstad
Copy link
Contributor

The compilation command 'bicep build' catches compilation errors as well as providing some lint warnings.

Repository for Bicep: https://github.com/Azure/bicep

The compilation command 'bicep build' catches compilation errors as well
as providing some lint warnings.

Repository for Bicep: https://github.com/Azure/bicep
\ get(g:, 'ale_bicep_bicep_executable', 'bicep')

let g:ale_bicep_bicep_options =
\ get(g:, 'ale_bicep_bicep_options', 'build --outfile /dev/null')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doubts about these default options:

  1. If users blindly set this variable then the linter most likely stop woking if they do not add "build --outfile /dev/null" also. Maybe better to force these options always in the ale_linters#bicep#bicep#Command() function?
  2. Not sure "/dev/null" would work on Windows platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points. I have hopefully addressed both of them.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@hsanson hsanson merged commit 8e03cee into dense-analysis:master Sep 13, 2022
@carlsmedstad carlsmedstad deleted the bicep-support branch September 21, 2022 21:42
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
* Add support for Microsoft's DSL Bicep

The compilation command 'bicep build' catches compilation errors as well
as providing some lint warnings.

Repository for Bicep: https://github.com/Azure/bicep

* Different null file on Windows & hardcode commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants