-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft's DSL Bicep #4310
Conversation
The compilation command 'bicep build' catches compilation errors as well as providing some lint warnings. Repository for Bicep: https://github.com/Azure/bicep
40d0f80
to
68100b3
Compare
ale_linters/bicep/bicep.vim
Outdated
\ get(g:, 'ale_bicep_bicep_executable', 'bicep') | ||
|
||
let g:ale_bicep_bicep_options = | ||
\ get(g:, 'ale_bicep_bicep_options', 'build --outfile /dev/null') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doubts about these default options:
- If users blindly set this variable then the linter most likely stop woking if they do not add "build --outfile /dev/null" also. Maybe better to force these options always in the ale_linters#bicep#bicep#Command() function?
- Not sure "/dev/null" would work on Windows platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points. I have hopefully addressed both of them.
15385e6
to
3063550
Compare
3063550
to
5349e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
* Add support for Microsoft's DSL Bicep The compilation command 'bicep build' catches compilation errors as well as providing some lint warnings. Repository for Bicep: https://github.com/Azure/bicep * Different null file on Windows & hardcode commands
The compilation command 'bicep build' catches compilation errors as well as providing some lint warnings.
Repository for Bicep: https://github.com/Azure/bicep