Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass options to the buf linter and fix callback. #4300

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Allow to pass options to the buf linter and fix callback. #4300

merged 2 commits into from
Sep 8, 2022

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Sep 4, 2022

  • Users may need to pass --disable-symlinks to the buf lint command.
  • The output of buf lint contains filenames, which will be ignored by ale#handlers#unix#HandleAsError, result that lint errors will be echoed in wrong files.
    An example output is:
another.proto:1:2:some error
this.proto:3:4:some error

It's same as the go#Handler and the buf tool is written in go.

@gou4shi1 gou4shi1 changed the title Allow to pass options to the buf linter Allow to pass options to the buf linter and fix callback. Sep 5, 2022
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@hsanson hsanson merged commit 477ad3f into dense-analysis:master Sep 8, 2022
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
…ysis#4300)

* Allow to pass options to the buf linter

* Fix the callback of buf linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants