Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openscad and sca2d support #4205

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Conversation

n8henrie
Copy link
Contributor

No description provided.

@n8henrie
Copy link
Contributor Author

n8henrie commented May 17, 2022

Hmmm, sorry about the failing lints. Having a hard time running the docker tests on my M1 mac.

Revision soon.

@n8henrie
Copy link
Contributor Author

n8henrie commented May 19, 2022

Man, I don't know what's going on with the tests, but ./run-tests [--fast] is hanging for ages on every run and rarely completing. Rebooted, tried deleting and redownloading the images. Wonder if it has to do with ARM / having to export DOCKER_DEFAULT_PLATFORM=linux/amd64.

Seems like letting CI do the feedback may end up being quicker.

@stale
Copy link

stale bot commented Jul 30, 2022

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Jul 30, 2022
@n8henrie
Copy link
Contributor Author

@w0rp -- I think this is just missing a review and otherwise could be merged.

@stale stale bot removed the stale PRs/Issues no longer valid label Jul 30, 2022
@hsanson
Copy link
Contributor

hsanson commented Aug 1, 2022

Tests are failing in Windows. Make sure to use ALE's path utils to ensure things work properly on all platforms.

@hsanson
Copy link
Contributor

hsanson commented Aug 1, 2022

    (1/1) [EXECUTE] (X) [{'lnum': 7, 'col': 42, 'filename': 'C:\home\projects\awesome_project.scad', 'type': 'E', 'text': 'Module `corcle` used but never defined.', 'detail': 'E2002: Module `corcle` used but never defined.'}] should be equal to [{'lnum': 7, 'col': 42, 'filename': '/home/projects/awesome_project.scad', 'type': 'E', 'text': 'Module `corcle` used but never defined.', 'detail': 'E2002: Module `corcle` used but never defined.'}]

@n8henrie
Copy link
Contributor Author

n8henrie commented Aug 2, 2022

Tests are failing in Windows.

Thanks for the feedback, I hadn't realized CI wasn't running on windows.

Tried with ale#path#Simplify, hopefully that does the trick.

@n8henrie
Copy link
Contributor Author

n8henrie commented Aug 2, 2022

Gah, I didn't scroll enough to see the appveyor failure (nor that it was an incomplete log on the site and needed to be downloaded). Should be able to get this passing now.

@n8henrie
Copy link
Contributor Author

n8henrie commented Aug 2, 2022

Looks like windows is finally passing so I've rebased and squashed.

supported-tools.md Outdated Show resolved Hide resolved
@hsanson hsanson merged commit 5063804 into dense-analysis:master Aug 7, 2022
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants