-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openscad and sca2d support #4205
Conversation
Hmmm, sorry about the failing lints. Having a hard time running the docker tests on my M1 mac. Revision soon. |
Man, I don't know what's going on with the tests, but Seems like letting CI do the feedback may end up being quicker. |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
@w0rp -- I think this is just missing a review and otherwise could be merged. |
Tests are failing in Windows. Make sure to use ALE's path utils to ensure things work properly on all platforms. |
|
Thanks for the feedback, I hadn't realized CI wasn't running on windows. Tried with |
Gah, I didn't scroll enough to see the appveyor failure (nor that it was an incomplete log on the site and needed to be downloaded). Should be able to get this passing now. |
Looks like windows is finally passing so I've rebased and squashed. |
No description provided.