omni-compl: start completion in a full keyword #4187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default `omni_start_map` is too restrictive for Lisps and Schemes like Racket, which permit hyphens (among other special characters). As recorded in dense-analysis#3870, trying to complete `file-name-from-path` when typing `file-name<C-x><C-o>` would give completions like `namespace` because the hyphen is ignored to find the start of the word for completion. Now the default searches for the start using the keyword class `\k`, which is more precise and configurable for each filetype without modifying the source.
|
Closed in favor of #4186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
omni_start_mapis too restrictive for Lisps and Schemeslike Racket, which permit hyphens (among other special characters).
As recorded in #3870, trying to complete
file-name-from-pathwhentyping
file-name<C-x><C-o>would give completions likenamespacebecause the hyphen is ignored to find the start of the word for
completion.
Now the default searches for the start using the keyword class
\k, which is more precise and configurable for each filetype withoutmodifying the source.